Update seastar module #6490
Open
Update seastar module #6490
+694
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hello @dotnwat, modules you maintain (seastar) have been updated in this PR. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a new BCR patch version for the seastar module. The changes introduce a BUILD.bazel overlay to provide Bazel support. My review focuses on adherence to the Bazel Central Registry style guide and best practices. I've identified a couple of areas for improvement: removing redundant dependency declarations in the version's MODULE.bazel file, and adding documentation for the generation of the large BUILD.bazel overlay, as recommended by the style guide.
modules/seastar/25.08.0-20250807194611-1520326e6032.bcr.1/MODULE.bazel
Outdated
Show resolved
Hide resolved
modules/seastar/25.08.0-20250807194611-1520326e6032.bcr.1/overlay/BUILD.bazel
Show resolved
Hide resolved
UebelAndre
force-pushed
the
seastar-update
branch
from
da53673 to
c8d0723
Compare
Contributor
Author
|
@bazel-io skip_check unstable_url |
bazel-io
added
the
skip-url-stability-check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated dependencies per conversation on #6441 (comment)